Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: upgrade http-spec #1044

Merged
merged 8 commits into from
Mar 16, 2020
Merged

fix: upgrade http-spec #1044

merged 8 commits into from
Mar 16, 2020

Conversation

XVincentX
Copy link
Contributor

@XVincentX XVincentX commented Mar 16, 2020

Needs the latest Http Spec package

Closes #1036

Copy link
Contributor

@karol-maciaszek karol-maciaszek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Builds locally, LGTM 👍

@@ -49,7 +49,7 @@ export function findDefaultContentType(

const byResponseCode = ord.contramap<number, IHttpOperationResponse>(ordNumber, response => parseInt(response.code));

export function findLowest2xx(httpResponses: NonEmptyArray<IHttpOperationResponse>): Option<IHttpOperationResponse> {
export function findLowest2xx(httpResponses: IHttpOperationResponse[]): Option<IHttpOperationResponse> {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

NonEmptyArray, I'll miss U 💔

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah I really thought this was something cool.

@XVincentX XVincentX marked this pull request as ready for review March 16, 2020 20:10
@XVincentX XVincentX merged commit 5eb884e into master Mar 16, 2020
@XVincentX XVincentX deleted the fix/security branch March 16, 2020 20:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Order of processing for securitySchemes
2 participants