Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add custom error for 2** #1035

Merged
merged 13 commits into from
Mar 13, 2020
Merged

feat: add custom error for 2** #1035

merged 13 commits into from
Mar 13, 2020

Conversation

XVincentX
Copy link
Contributor

@XVincentX XVincentX commented Mar 13, 2020

Create a specific error for Prism when it cannot find a suitable 2XX response so we can differentiate with something that's not under our control

@XVincentX XVincentX requested review from karol-maciaszek, marcelltoth and pytlesk4 and removed request for karol-maciaszek March 13, 2020 00:18
packages/http-server/src/server.ts Outdated Show resolved Hide resolved
packages/http/src/mocker/errors.ts Outdated Show resolved Hide resolved
Co-Authored-By: Karol Maciaszek <[email protected]>
Copy link
Contributor

@karol-maciaszek karol-maciaszek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

Copy link
Contributor

@marcelltoth marcelltoth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The error title could be updated as we agreed, other than that it LGTM.

@XVincentX XVincentX merged commit 348132d into master Mar 13, 2020
@XVincentX XVincentX deleted the fix/200_responseError branch March 13, 2020 13:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants