Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: detect preflight requests #1031

Merged
merged 8 commits into from
Mar 11, 2020
Merged

fix: detect preflight requests #1031

merged 8 commits into from
Mar 11, 2020

Conversation

XVincentX
Copy link
Contributor

@XVincentX XVincentX commented Mar 10, 2020 •
edited
Loading

Closes #1020

@Primajin
Copy link

Thank you this helps us a lot in our development of data driven UIs 😄

marcelltoth
marcelltoth approved these changes Mar 11, 2020
View reviewed changes
Copy link
Contributor

@marcelltoth marcelltoth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we have a counter-example harness test, which tests an actual preflight request?

With that condition, it looks good to me.

I added 2 comments though, I know they are inherited code, still something to consider.

packages/http-server/src/server.ts Show resolved Hide resolved
packages/http-server/src/server.ts Show resolved Hide resolved
karol-maciaszek
karol-maciaszek approved these changes Mar 11, 2020
View reviewed changes
Copy link
Contributor

@karol-maciaszek karol-maciaszek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, just curious about the Content-length case mentioned by @marcelltoth

@XVincentX XVincentX merged commit ab2a899 into master Mar 11, 2020
@XVincentX XVincentX deleted the fix/cors-options branch March 11, 2020 17:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marcelltoth marcelltoth marcelltoth approved these changes

@karol-maciaszek karol-maciaszek karol-maciaszek approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

CORS Headers Options verb
4 participants
@XVincentX @Primajin @marcelltoth @karol-maciaszek