Skip to content

Conversation

@P0lip
Copy link
Contributor

@P0lip P0lip commented Nov 30, 2021

#179 (comment)

at this point it feels appropriate to remove the snapshots.
Let me explain why I added them in the first place.
About a year ago I was moving the whole logic off to JST. This is the PR that introduced the following snapshots #92.
Once JST was founded, I incorporated it over here #91 and these snapshots were very helpful and ensured me that JST didn't have any meaningful impact on the UI.
Besides a few new tests and actual bug fixes (JST did help to fix a number of bugs as well as improved the overall processing of schemas), the snapshots were left untouched.

Now, when we actively work on UI, they don't have any value.

@P0lip P0lip added the chore label Nov 30, 2021
@P0lip P0lip requested review from a team and domagojk November 30, 2021 21:40
@P0lip P0lip self-assigned this Nov 30, 2021
@marbemac
Copy link
Contributor

👍 can we remove code climate while we're at it? we don't use it anymore in our ecosystem

@marbemac marbemac requested review from Nezteb and removed request for domagojk November 30, 2021 22:01
@P0lip
Copy link
Contributor Author

P0lip commented Nov 30, 2021

@marbemac we don't have any code related to CC in our repo.
I think it just works because it's an open-source project and we have some webhooks attached.
can prob remove it here https://codeclimate.com/repos/5c407ac419d5de0257011e41/edit I guess?


Done

@P0lip P0lip merged commit 9e58adf into master Dec 1, 2021
@P0lip P0lip deleted the chore/remove-snapshots branch December 1, 2021 08:17
@stoplight-bot
Copy link
Collaborator

🎉 This PR is included in version 4.4.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants