perf: replace lodash's cloneDeep with fast-copy #2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
P0lip
approved these changes
Mar 18, 2021
P0lip
left a comment
P0lip
left a comment
There was a problem hiding this comment.
👍
and yeah, if I am not mistaken _.cloneDeep was never quite meant to be efficient.
The primary use case was to be able to clone a number of different data structures, and this is where cloneDeep shines.
I'll add this to my TODO list. I'll try to get rid of deep cloning entirely, as this is useless if you combine it with deep flag.
P0lip
pushed a commit
that referenced
this pull request
Mar 18, 2021
This was referenced Mar 24, 2021
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As the title says.
Unfortunately the library currently relies heavily on deep cloning, which takes up the bulk of the run-time.
This PR replaces the original deep-clone implementation (lodash'sh
cloneDeep) withfast-copy. This tiny change alone makes JST run 20% faster on the stress test schema, which is fascinating. (And an indication of how inefficient this lib is.)