Chore/package update json schema viewer #2163
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brendarearden
requested review from
a team and
kaylachun
and removed request for
a team
✅ Deploy Preview for stoplight-elements-demo ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
✅ Deploy Preview for stoplight-elements-dev-portal-storybook ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
✅ Deploy Preview for stoplight-elements ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
kaylachun
reviewed
Jun 7, 2022
| "version": "1.7.4", | ||
| "description": "UI components for composing beautiful developer documentation.", | ||
| "keywords": [], | ||
| "sideEffects": [ |
There was a problem hiding this comment.
Line 62: does elements-core version need bumping here?
There was a problem hiding this comment.
good catch - I have bumped the version on line 62!
kaylachun
reviewed
Jun 7, 2022
packages/elements/package.json
Outdated
| }, | ||
| "dependencies": { | ||
| "@fortawesome/free-solid-svg-icons": "^5.14.0", | ||
| "@stoplight/elements-core": "~7.5.19", |
There was a problem hiding this comment.
bump version here as well?
There was a problem hiding this comment.
This has been bumped in the most recent commit
kaylachun
approved these changes
Jun 8, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Elements Default PR Template
In general, make sure you have: (check the boxes to acknowledge you've followed this template)
CONTRIBUTING.mdOther Available PR Templates:
CONTRIBUTING.mdDescription
stoplightio/json-schema-viewer#198 changes to json-schema-viewer prompted package version bump in elements-core.