Skip to content

fix: docs crashing in cra #1520

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jun 30, 2021
Merged

fix: docs crashing in cra #1520

merged 2 commits into from
Jun 30, 2021

Conversation

@mpodlasin
Copy link
Contributor

Fixes #1519

@mpodlasin mpodlasin requested a review from philsturgeon as a code owner June 30, 2021 12:04
@mpodlasin mpodlasin requested review from a team and mmiask June 30, 2021 12:04
@netlify
Copy link

netlify bot commented Jun 30, 2021 •
edited
Loading

✔️ Deploy Preview for stoplight-elements-dev-portal-storybook ready!

🔨 Explore the source changes: ff9cda6

🔍 Inspect the deploy log: https://app.netlify.com/sites/stoplight-elements-dev-portal-storybook/deploys/60dc6df10fe1e00007b8b7d9

😎 Browse the preview: https://deploy-preview-1520--stoplight-elements-dev-portal-storybook.netlify.app

@netlify
Copy link

netlify bot commented Jun 30, 2021 •
edited
Loading

✔️ Deploy Preview for stoplight-elements ready!

🔨 Explore the source changes: ff9cda6

🔍 Inspect the deploy log: https://app.netlify.com/sites/stoplight-elements/deploys/60dc6df1f1e5da0008a7b959

😎 Browse the preview: https://deploy-preview-1520--stoplight-elements.netlify.app

@netlify
Copy link

netlify bot commented Jun 30, 2021 •
edited
Loading

✔️ Deploy Preview for stoplight-elements-demo ready!

🔨 Explore the source changes: ff9cda6

🔍 Inspect the deploy log: https://app.netlify.com/sites/stoplight-elements-demo/deploys/60dc6df19410cb0007968a09

😎 Browse the preview: https://deploy-preview-1520--stoplight-elements-demo.netlify.app

@marcelltoth marcelltoth removed the request for review from mmiask June 30, 2021 13:13
@mpodlasin mpodlasin enabled auto-merge (squash) June 30, 2021 13:13
@mpodlasin mpodlasin merged commit 3ac7976 into main Jun 30, 2021
@mpodlasin mpodlasin deleted the fix/docs-crashing-in-cra branch June 30, 2021 13:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

2 more reviewers

@philsturgeon philsturgeon philsturgeon approved these changes

@marcelltoth marcelltoth marcelltoth approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Object is not a function (duh)

4 participants

@mpodlasin @philsturgeon @marcelltoth