[Not serious - Do not merge] TypeScript metalanguage $ref resolution#1391
Closed
marcelltoth wants to merge 13 commits intomainfrom
Closed
[Not serious - Do not merge] TypeScript metalanguage $ref resolution#1391marcelltoth wants to merge 13 commits intomainfrom
marcelltoth wants to merge 13 commits intomainfrom
Conversation
Because why not
|
Kudos, SonarCloud Quality Gate passed!
|
Contributor
|
Closing with sadness. @marcelltoth still waiting for that article about what happened here! :D |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@mpodlasin I was annoyed that we can't type the $ref resolver correctly, so I tried... 😇
And it looks like it works. Doesn't handle everything yet - I'll probably not do the rest because this entire PR was just a random challenge - but it passes the 2 basic tests and also the circular one.
TS 4.3 needed because microsoft/TypeScript#43060