-
Notifications
You must be signed in to change notification settings - Fork 251
feat: update to mosaic based markdown-viewer #1359
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
# Conflicts: # packages/elements-core/package.json # packages/elements-core/src/components/MarkdownViewer/CustomComponents/CodeComponent.tsx # packages/elements-core/src/components/SchemaAndDescription/index.tsx # yarn.lock
# Conflicts: # packages/elements-dev-portal/package.json # yarn.lock
|
✔️ Deploy Preview for stoplight-elements-dev-portal-storybook ready! 🔨 Explore the source changes: ee19f0e 🔍 Inspect the deploy log: https://app.netlify.com/sites/stoplight-elements-dev-portal-storybook/deploys/60b6b9e53b0b18000791f29c 😎 Browse the preview: https://deploy-preview-1359--stoplight-elements-dev-portal-storybook.netlify.app |
|
✔️ Deploy Preview for stoplight-elements ready! 🔨 Explore the source changes: ee19f0e 🔍 Inspect the deploy log: https://app.netlify.com/sites/stoplight-elements/deploys/60b6b9e5be9b7600070239ec 😎 Browse the preview: https://deploy-preview-1359--stoplight-elements.netlify.app |
|
✔️ Deploy Preview for stoplight-elements-demo ready! 🔨 Explore the source changes: ee19f0e 🔍 Inspect the deploy log: https://app.netlify.com/sites/stoplight-elements-demo/deploys/60b6b9e547ff4e0007797101 😎 Browse the preview: https://deploy-preview-1359--stoplight-elements-demo.netlify.app |
|
Somehow I missed this PR, but I did exactly that in #1360 so I think we can continue there. I just need to update it with bumped mdv and jsv to make it run with cra example |
|
Closing this as #1360 was merged. Feel free to reopen if you feel like that PR fails to cover something that's implemented here. |
Related to #957
Description tbd
Todos
json-schema-viewer(fix: bump markdown-viewer, remove ui-kit json-schema-viewer#148)