fix: docs ui #1033
fix: docs ui #1033
Conversation
|
Deploy preview for stoplight-elements ready! Built with commit 60cd548 |
| }: ISchemaViewerProps) => { | ||
| const [selectedIndex, setSelectedIndex] = React.useState(0); | ||
|
|
||
| export const SchemaViewer = ({ className, title, description, schema, errors, viewMode }: ISchemaViewerProps) => { |
There was a problem hiding this comment.
I don't like this name.
What is the difference between JsonSchemaViewer and SchemaViewer? 😂
I would go for something like SchemaWithDescription? DescriptionAndSchema?
There was a problem hiding this comment.
I used SchemaViewer as there was ISchemaViewerProps interface.
SchemaWithDescription might be fine as it was SchemaWithExamples before.
What do you mean? What's wring with this schema? |
That's that whole page. Does this look good? Just a blank page with a schema? No title? 🤔
|
|
Should there be a title? There's no title in schema, we could just show a name like in toc but there wasn't anything before and that wasn't the requirement so I didn't touch it. |
You are right. This is not a regression. I thought it was. No problem then! |
Fixes: stoplightio/json-schema-viewer#122
Needs: stoplightio/json-schema-viewer#132 for jsv divider light color.Batch of ui fixes (not so mega in the end).