Support forward slash on branch name #3
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
April 19, 2024 14:19
Using branches with forward slashes in their names causes two problems: 1. Log files are not created, because the script tries to create the log file in a subdirectory. 2. The script fails to checkout versions other than the initial checked out one because the initial checkout directory is not empty on subsequent tries. It also fails to create temp directories. Tested with branch name `add/playground-theme-preview` ``` [Fri Apr 19 14:10:46 2024] PHP Warning: mkdir(): No such file or directory in /Users/vcanales/dev/github-proxy/proxy.php on line 66 [Fri Apr 19 14:10:46 2024] PHP Warning: chdir(): No such file or directory (errno 2) in /Users/vcanales/dev/github-proxy/proxy.php on line 67 fatal: destination path 'themes' already exists and is not an empty directory. ```
Improves readability
vcanales
commented
Apr 19, 2024
Comment on lines
+22
to
+23
| $repo_name = explode('/', $repo); | ||
| $repo_name = end($repo_name); |
There was a problem hiding this comment.
This gets rid of this warning, which shows up on my system with php 8.3.6.
<b>Notice</b>: Only variables should be passed by reference in <b>/Users/vcanales/dev/github-proxy/proxy.php</b> on line <b>22</b><br />
stoph
added a commit
that referenced
this pull request
Apr 23, 2024
Integrating code from #3 Co-Authored-By: Vicente Canales <[email protected]>
vcanales
pushed a commit
to WordPress/community-themes
that referenced
this pull request
Apr 24, 2024
Changing where we make the call to download the theme, to make sure that we're using stable code. Additionally, add child theme handling. Discussion around this: - Automattic/themes#7719 - stoph/github-proxy#3
MaggieCabrera
added a commit
to WordPress/community-themes
that referenced
this pull request
Apr 24, 2024
* Playground Previews: use correct github proxy URL Changing where we make the call to download the theme, to make sure that we're using stable code. Additionally, add child theme handling. Discussion around this: - Automattic/themes#7719 - stoph/github-proxy#3 * change on a child theme * pushed another test * remove tests * Update .github/scripts/create-preview-links.js --------- Co-authored-by: MaggieCabrera <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using branches with forward slashes in their names causes two problems:
add/playground-theme-previewThis also creates a corrupt .zip file: