docs: freeze measured embedding benchmark result - #232
Conversation
|
Warning Review limit reached
Next review available in: 7 minutes Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (5)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: a406fb3730
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| "schemaVersion": "context-engine-embedding-benchmark-frozen-result-v1" | ||
| "schemaVersion": "context-engine-embedding-benchmark-frozen-result-v1", | ||
| "verdict": { | ||
| "activationAcceptanceReference": "https://github.com/stone16/context-engine/issues/128#issuecomment-5161569127", |
There was a problem hiding this comment.
Replace the hard-coded acceptance URL
stometa, when the repository moves or the linked issue comment becomes unavailable, this frozen verdict loses its only pointer to the acceptance evidence. Store a stable repository-owned evidence reference instead of embedding the volatile GitHub URL, as required by the repository charter.
AGENTS.md reference: AGENTS.md:L94-L96
Useful? React with 👍 / 👎.
Closes #128
Outcome
pending_corpusplaceholder with the reviewed,aggregate-only 30-case benchmark result and exact run identity;
0.5666666667) versusmultilingual-e5-small at 13/30 (
0.4333333333) across case hit, macroEvidence recall, and micro Evidence recall;
activated-profile acceptance: Qwen 7/28 (
0.25) versus twin 0/28 (0.0);the existing privacy test; the full report and per-slice material remain in
the ignored
.context-engineroot;naming and discoverable disclosure of the temporary timeout refusal-category
conflation.
Definition of Done mapping
test_embedding_benchmark_identity.py.test_embedding_benchmark_report_schema.py.test_embedding_benchmark_metrics.pyandtest_embedding_benchmark_retrieval_judge.py.test_embedding_benchmark_determinism.py.test_embedding_benchmark_runtime_untouched.py; this diff changes neither.test_embedding_benchmark_report_privacy.pyfreezes the exact object andrejects query/title/path/excerpt keys and personal paths.
test_embedding_provider_validation.py.test_embedding_benchmark_cli.py; fresh--helpalso passed.identity, top-k 10, 4,166-document count, 30-case metrics, and timings from
the schema-valid ignored report.
Pareto rule, states the win against the 3.8% twin baseline, and records the
activated online 7/28 versus 0/28 reference.
unchanged M0 veto on the preserved dogfood database at schema
20260803_0055.All issue DoD boxes are evidenced; there is no remaining closure blocker.
Verification
uv run context-engine-embedding-benchmark --help: PASSmake lint: PASSmake typecheck: PASS (mypy 513 sources plus TypeScript)make test: PASS (2,619 tests)make security-gate: M0 SECURITY PASS (187 retained tests; repository andlive database both at
20260803_0055)git diff --check: PASSNo production Runtime composition or embedding dimension constant changes.