Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replaced ping setInterval integration with webworker #579

Open
wants to merge 4 commits into
base: develop
Choose a base branch
from

Conversation

tomamatics
Copy link

@tomamatics tomamatics commented Jul 30, 2023

The use of setInterval can be paused by the OS as soon as the browser tab or mobile browser app is in the background. Due to this behavior, the Stomp client library no longer sends ping messages and the Stomp server will close the connection. By using a webworker, the affected code will continue to run and ping-messages will be sent, even if the tab/app is not active.

@kum-deepak
Copy link
Member

This does look interesting and useful. A couple of feedback:

  • Looking at the automated runs, this scheme does not work on NodeJS.
  • We can add checks if WebWorkers are available and use the new behavior accordingly.
  • In addition, we can introduce a flag to control this behavior.

Please only commit changes to the src folder. Makes it easier to review and compare.

@kum-deepak
Copy link
Member

Many thanks! The code looks beautiful. Please allow me a few days to review this.

I may have a few suggestions - those will be optional. In addition, if possible, we should figure out to include it as part of the tests as well.

@tomamatics
Copy link
Author

Thanks for the review. Again, i fixed some minor issues. Tests should be running now.

@kum-deepak
Copy link
Member

Will release as pert of v7.1

@drando
Copy link

drando commented Sep 1, 2023

Hi! sorry to ask, do you have an estimated ETA for v7.1? can't find that info, and this would be great to finally resolve the issue about timers throttled in chrome. Thanks!

@ianninirojas
Copy link

Hi, does anyone know when v7.1 will be released. Sorry if this question makes anyone uncomfortable. Greetings.

@tschlechtweg
Copy link

Please refrain from asking for the release (and for anything else for that matter), as it will:

  1. Spam everybody's inbox that subscribed to this ticket
  2. Does not help in releasing this faster to the public
  3. Is straight up annoying

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants