Add release-2.17 tekton pipelines and update configurations#2320
Merged
Conversation
📝 WalkthroughWalkthroughBump release identifiers from 1.7 → 1.8 and update related branch trigger from release-2.16 → release-2.17 across Tekton pipelines, container metadata, operator bundle/manifests, Makefile, renovate config, and a GitHub workflow step. No functional logic or runtime behavior changes. Changes
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes Poem
🚥 Pre-merge checks | ✅ 2 | ❌ 1❌ Failed checks (1 inconclusive)
✅ Passed checks (2 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
- Add new .tekton/ pipelines for globalhub-1-8 (target_branch=main) - Remove previous release pipeline files (globalhub-1-7) - Update Containerfile version labels to release-1.8 - Update GitHub workflow bundle branch to release-1.8 - Update renovate.json baseBranches (maintain main + last 3 releases) - Update operator Makefile (VERSION, CHANNELS, DEFAULT_CHANNEL) - Update CSV (skipRange, ACM version, maturity) - Regenerate operator bundle ACM: release-2.17, Global Hub: release-1.8 Signed-off-by: myan <myan@redhat.com>
yanmxa
force-pushed
the
release-2.17-tekton-configs
branch
from
575682b to
dcff991
Compare
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In
`@operator/config/manifests/bases/multicluster-global-hub-operator.clusterserviceversion.yaml`:
- Line 223: The CSV's user-facing OLM description contains a typo: the word
"Multicluser" should be "Multicluster"; update the string containing
"Multicluser GlobalHub Documentation" to "Multicluster GlobalHub Documentation"
(search for the exact "Multicluser" token in the CSV/OLM description field) and
then regenerate the operator bundle so the corrected text is propagated to all
generated manifests.
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
Run ID: 531bfac8-5418-4721-bab8-92c9220a757b
📒 Files selected for processing (15)
.github/workflows/go.yml.tekton/multicluster-global-hub-agent-globalhub-1-8-pull-request.yaml.tekton/multicluster-global-hub-agent-globalhub-1-8-push.yaml.tekton/multicluster-global-hub-manager-globalhub-1-8-pull-request.yaml.tekton/multicluster-global-hub-manager-globalhub-1-8-push.yaml.tekton/multicluster-global-hub-operator-globalhub-1-8-pull-request.yaml.tekton/multicluster-global-hub-operator-globalhub-1-8-push.yamlagent/Containerfile.agentmanager/Containerfile.manageroperator/Containerfile.operatoroperator/Makefileoperator/bundle/manifests/multicluster-global-hub-operator.clusterserviceversion.yamloperator/bundle/metadata/annotations.yamloperator/config/manifests/bases/multicluster-global-hub-operator.clusterserviceversion.yamlrenovate.json
🚧 Files skipped from review as they are similar to previous changes (7)
- agent/Containerfile.agent
- .tekton/multicluster-global-hub-manager-globalhub-1-8-pull-request.yaml
- .tekton/multicluster-global-hub-manager-globalhub-1-8-push.yaml
- operator/Makefile
- operator/Containerfile.operator
- .tekton/multicluster-global-hub-agent-globalhub-1-8-push.yaml
- .github/workflows/go.yml
| ## Documentation | ||
| For documentation about installing and using the Multicluster GlobalHub Operator with Red Hat Advanced Cluster Management for | ||
| Kubernetes, see [Multicluser GlobalHub Documentation](https://access.redhat.com/documentation/en-us/red_hat_advanced_cluster_management_for_kubernetes/2.16/html-single/multicluster_global_hub/index#doc-wrapper) in the Red Hat Advanced Cluster Management | ||
| Kubernetes, see [Multicluser GlobalHub Documentation](https://access.redhat.com/documentation/en-us/red_hat_advanced_cluster_management_for_kubernetes/2.17/html-single/multicluster_global_hub/index#doc-wrapper) in the Red Hat Advanced Cluster Management |
There was a problem hiding this comment.
Fix the documentation label typo in the CSV copy.
Multicluser is misspelled in this user-facing OLM text. Fix it here and regenerate the bundle so both manifests stay in sync.
✏️ Suggested fix
- Kubernetes, see [Multicluser GlobalHub Documentation](https://access.redhat.com/documentation/en-us/red_hat_advanced_cluster_management_for_kubernetes/2.17/html-single/multicluster_global_hub/index#doc-wrapper) in the Red Hat Advanced Cluster Management
+ Kubernetes, see [Multicluster Global Hub Documentation](https://access.redhat.com/documentation/en-us/red_hat_advanced_cluster_management_for_kubernetes/2.17/html-single/multicluster_global_hub/index#doc-wrapper) in the Red Hat Advanced Cluster Management📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
Suggested change
| Kubernetes, see [Multicluser GlobalHub Documentation](https://access.redhat.com/documentation/en-us/red_hat_advanced_cluster_management_for_kubernetes/2.17/html-single/multicluster_global_hub/index#doc-wrapper) in the Red Hat Advanced Cluster Management | |
| Kubernetes, see [Multicluster Global Hub Documentation](https://access.redhat.com/documentation/en-us/red_hat_advanced_cluster_management_for_kubernetes/2.17/html-single/multicluster_global_hub/index#doc-wrapper) in the Red Hat Advanced Cluster Management |
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.
In
`@operator/config/manifests/bases/multicluster-global-hub-operator.clusterserviceversion.yaml`
at line 223, The CSV's user-facing OLM description contains a typo: the word
"Multicluser" should be "Multicluster"; update the string containing
"Multicluser GlobalHub Documentation" to "Multicluster GlobalHub Documentation"
(search for the exact "Multicluser" token in the CSV/OLM description field) and
then regenerate the operator bundle so the corrected text is propagated to all
generated manifests.
|
Contributor
Author
|
/retest |
Contributor
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: clyang82, yanmxa The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Add new pipeline configurations for release-2.17 to the main branch.
Changes
globalhub-1-8:*-pull-request.yaml:target_branch=main*-push.yaml:target_branch=release-2.17globalhub-1-7)release-1.8release-1.8Release Info
Note
This PR updates all necessary configurations for the new release on the main branch.
Summary by CodeRabbit