Skip to content

Remove failing upstream Grafana workflows#198

Merged
clyang82 merged 1 commit into
stolostron:release-1.7from
yanmxa:remove-relyance-workflow
Feb 10, 2026
Merged

Remove failing upstream Grafana workflows#198
clyang82 merged 1 commit into
stolostron:release-1.7from
yanmxa:remove-relyance-workflow

Conversation

@yanmxa
Copy link
Copy Markdown

@yanmxa yanmxa commented Feb 9, 2026

Summary

This PR removes two Grafana upstream workflows that are not applicable to the stolostron/glo-grafana fork and have been causing failures.

Problems Identified

1. Relyance Compliance Inspection

2. Dispatch sync to mirror

  • Status: Fails when triggered on release branches
  • Root cause: The workflow contains if: github.repository == 'grafana/grafana' condition, meaning it only executes for the upstream repository, not for forks. However, it still attempts vault access in earlier steps, causing failures.

Solution

Remove both workflow files:

  • .github/workflows/relyance-scan.yml
  • .github/workflows/sync-mirror-event.yml

Analysis of Other Workflows

Reviewed other workflows that use vault secrets or have upstream-specific conditions. Most are either:

  1. Protected by if: github.repository == 'grafana/grafana' conditions (will be skipped)
  2. Triggered only via workflow_call or workflow_dispatch (manual/called, not automatic)
  3. Working correctly in the stolostron fork

Related

🤖 Generated with Claude Code

@openshift-ci
Copy link
Copy Markdown

openshift-ci Bot commented Feb 9, 2026

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: yanmxa
Once this PR has been reviewed and has the lgtm label, please assign philipgough for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Remove workflows that are not applicable to stolostron/glo-grafana:

1. relyance-scan.yml - Fails with 401 Unauthorized when accessing vault
   Error: failed to retrieve vault token (ERR_NON_2XX_3XX_RESPONSE: Response code 401)
   Reference: https://github.com/stolostron/glo-grafana/actions/runs/21808224596

2. sync-mirror-event.yml - Only executes for grafana/grafana repository
   Contains condition: if: github.repository == 'grafana/grafana'
   This workflow never actually runs in stolostron fork, but attempts vault
   access causing failures.

These workflows are inherited from upstream Grafana but are not configured
or needed for the Global Hub fork.

Signed-off-by: Meng Yan <myan@redhat.com>
@yanmxa yanmxa force-pushed the remove-relyance-workflow branch from 2123d5c to d92d51c Compare February 9, 2026 04:57
@yanmxa yanmxa changed the title Remove failing Relyance compliance workflow Remove failing upstream Grafana workflows Feb 9, 2026
@yanmxa
Copy link
Copy Markdown
Author

yanmxa commented Feb 9, 2026

The Konflux pipeline failed due to:

  1. sast-unicode-check task failed (ran for 14 minutes)
  2. sast-snyk-check task was cancelled due to pipeline timeout

The failure appears to be related to security scanning tasks, not the actual code changes (which only remove workflow files). All build-images tasks succeeded.

Could you help re-trigger the Konflux pipeline or investigate the sast-unicode-check failure? The changes in this PR only delete two unused workflow files and shouldn't affect the build process.

@yanmxa
Copy link
Copy Markdown
Author

yanmxa commented Feb 9, 2026

/retest

@clyang82 clyang82 merged commit b638a22 into stolostron:release-1.7 Feb 10, 2026
21 of 22 checks passed
ldpliu added a commit to ldpliu/glo-grafana that referenced this pull request Apr 1, 2026
This commit applies all Global Hub specific changes on top of
stolostron/grafana release-2.17 (Grafana v12.4.0):

- Apply Global Hub Konflux config and CVE fixes (stolostron#190)
- Remove failing upstream Grafana workflows (stolostron#197, stolostron#198)
- Upgrade golang to 1.25.7 and use common-base.yaml (stolostron#199)
- Update glo-grafana for release-1.8 (Global Hub v1.8.0) (stolostron#203)

Signed-off-by: Deping Liu <dpliu@redhat.com>
Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Signed-off-by: root <daliu@redhat.com>
ldpliu added a commit that referenced this pull request Apr 1, 2026
This commit applies all Global Hub specific changes on top of
stolostron/grafana release-2.17 (Grafana v12.4.0):

- Apply Global Hub Konflux config and CVE fixes (#190)
- Remove failing upstream Grafana workflows (#197, #198)
- Upgrade golang to 1.25.7 and use common-base.yaml (#199)
- Update glo-grafana for release-1.8 (Global Hub v1.8.0) (#203)

Signed-off-by: Deping Liu <dpliu@redhat.com>
Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Signed-off-by: root <daliu@redhat.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants