Remove failing upstream Grafana workflows#198
Conversation
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: yanmxa The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
Remove workflows that are not applicable to stolostron/glo-grafana: 1. relyance-scan.yml - Fails with 401 Unauthorized when accessing vault Error: failed to retrieve vault token (ERR_NON_2XX_3XX_RESPONSE: Response code 401) Reference: https://github.com/stolostron/glo-grafana/actions/runs/21808224596 2. sync-mirror-event.yml - Only executes for grafana/grafana repository Contains condition: if: github.repository == 'grafana/grafana' This workflow never actually runs in stolostron fork, but attempts vault access causing failures. These workflows are inherited from upstream Grafana but are not configured or needed for the Global Hub fork. Signed-off-by: Meng Yan <myan@redhat.com>
2123d5c to
d92d51c
Compare
|
The Konflux pipeline failed due to:
The failure appears to be related to security scanning tasks, not the actual code changes (which only remove workflow files). All build-images tasks succeeded. Could you help re-trigger the Konflux pipeline or investigate the sast-unicode-check failure? The changes in this PR only delete two unused workflow files and shouldn't affect the build process. |
|
/retest |
This commit applies all Global Hub specific changes on top of stolostron/grafana release-2.17 (Grafana v12.4.0): - Apply Global Hub Konflux config and CVE fixes (stolostron#190) - Remove failing upstream Grafana workflows (stolostron#197, stolostron#198) - Upgrade golang to 1.25.7 and use common-base.yaml (stolostron#199) - Update glo-grafana for release-1.8 (Global Hub v1.8.0) (stolostron#203) Signed-off-by: Deping Liu <dpliu@redhat.com> Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com> Signed-off-by: root <daliu@redhat.com>
This commit applies all Global Hub specific changes on top of stolostron/grafana release-2.17 (Grafana v12.4.0): - Apply Global Hub Konflux config and CVE fixes (#190) - Remove failing upstream Grafana workflows (#197, #198) - Upgrade golang to 1.25.7 and use common-base.yaml (#199) - Update glo-grafana for release-1.8 (Global Hub v1.8.0) (#203) Signed-off-by: Deping Liu <dpliu@redhat.com> Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com> Signed-off-by: root <daliu@redhat.com>
Summary
This PR removes two Grafana upstream workflows that are not applicable to the stolostron/glo-grafana fork and have been causing failures.
Problems Identified
1. Relyance Compliance Inspection
failed to retrieve vault token. code: ERR_NON_2XX_3XX_RESPONSE, message: Response code 401 (Unauthorized)2. Dispatch sync to mirror
if: github.repository == 'grafana/grafana'condition, meaning it only executes for the upstream repository, not for forks. However, it still attempts vault access in earlier steps, causing failures.Solution
Remove both workflow files:
.github/workflows/relyance-scan.yml.github/workflows/sync-mirror-event.ymlAnalysis of Other Workflows
Reviewed other workflows that use vault secrets or have upstream-specific conditions. Most are either:
if: github.repository == 'grafana/grafana'conditions (will be skipped)workflow_callorworkflow_dispatch(manual/called, not automatic)Related
🤖 Generated with Claude Code