have cli watch template file for changes #91
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tuliren
approved these changes
Dec 22, 2022
| import { Template } from '../../../../action/src/types'; | ||
|
|
||
| import { findStoatConfigPath } from '../pathHelpers'; | ||
| import {findGitRoot, findStoatConfigPath} from '../pathHelpers'; |
There was a problem hiding this comment.
Nitpick. The code is not auto formatted. husky is probably not working for cli.
There was a problem hiding this comment.
Updated to what I think is a better husky configuration. There's no root .husky now, only .husky/pre-commit for subprojects.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a bug previously where if this was run from a subdirectory, it would always use the default remote template, since it wouldn't find the local one where it expected. That's fixed in this PR.
Also, while it would detect a change in specified template file in the Stoat config file, it wouldn't update automatically on changes within the template itself, which would require restarting
stoat local. This wouldn't be that big of a deal except the one of the biggest reasons to use local mode is to fine tune the template.I created #90 to track an issue that would make it trivial to locally iterate on templates including non-
static_hostingplugins. Maybe we could even have a copy button on debug pages next to the merged configs that just gives you the command to run locally to preview that exact config.