-
Notifications
You must be signed in to change notification settings - Fork 237
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Constructors #324
Constructors #324
Conversation
This is amazing! Calling the constructor and destructors "manually" from crt0 (and not using I will have a closer look at your code but I think I am absolutely fine with merging this as-is. 👍 edit Maybe we should merge #323 first to avoid too much merge conflicts here. |
@GideonZ you are OK with the changes? |
Absolutely. I saw a few typos in the documentation that you may want to have a look at, but it's just minor. Actually I admire your diligence of updating the documentation with these changes! |
As promised, hereby the pull request with the necessary changes to the crt0.s and linker script to support the proper initialization of C++ objects by calling the constructors. A small demo shows that the static objects have been initialized properly.