Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[docs/makefile] Copy figures also for single targets #1101

Merged
merged 4 commits into from
Nov 26, 2024

Conversation

LukasP46
Copy link
Contributor

Hey all,
as I only want to generate html, I added

  • the figures-copy as target
  • dependencies on it for the html targets
  • targets for folders and dependencies on it

I would welcome if someone could test if I broke the other targets as I cannot evaluate it currently.

@LukasP46
Copy link
Contributor Author

I found a bug in the doxygen artifact: neorv32_logo_riscv.png and neorv32_processor.png are missing for the md_README.html. I'll fix it by copying all images to the acording folder, although there are some resources that will never be used. The other two methods would be to put the individual files in the makefile - no overhead, but needs to be maintained, or by automatically determining which images are needed - which seems overkill.

@stnolting
Copy link
Owner

Hey @LukasP46.

Thanks for the update / cleanup!

I would welcome if someone could test if I broke the other targets as I cannot evaluate it currently.

Seems to work on my side.

'll fix it by copying all images to the acording folder, although there are some resources that will never be used

Thanks for fixing!

The other two methods would be to put the individual files in the makefile - no overhead, but needs to be maintained, or by automatically determining which images are needed - which seems overkill.

I agree, this seems to be an overkill.

So I think this is ready for merging, right?

@stnolting stnolting added the DOC Improvements or additions to documentation label Nov 26, 2024
@stnolting stnolting merged commit 5b9c766 into stnolting:main Nov 26, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
DOC Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants