Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[vivado ip] make m_axi (XBUS) interface optional #1067

Merged
merged 4 commits into from
Oct 19, 2024

Conversation

donlon
Copy link
Collaborator

@donlon donlon commented Oct 18, 2024

Hey thank you for merging my recent pulls! And here's the last split of #1060.

As mentioned in #1060 (comment) did you encounter any error from the tool? It works fine for me on my computer with Vivado 2022.2.

@stnolting
Copy link
Owner

stnolting commented Oct 18, 2024

When I disable the XBUS interface the according input ports are terminated according to the VHDL defaults. However, in my (auto-generated) VHDL top wrapper this is done in a "Verilog style" (using a literal) instead of using VHDL's (others => '0') statement:

grafik

This is one of the faulting lines:

m_axi_rresp => X"3",

m_axi_rresp is only 2-bits wide, but X"3" implies a 4-bit width.

Are you using a Verilog top wrapper?

@stnolting
Copy link
Owner

I just removed the default values for AXI ports whose bit-width is not 1 or a power of two and this seems to fix this issue. 🚀

@stnolting
Copy link
Owner

This seems ready from my side. @donlon can you have another look at it?

@donlon
Copy link
Collaborator Author

donlon commented Oct 19, 2024

Oops forget to synthesize the generated core...My Vivado also generate the same wrapper that results in the width mismatch errors, and removing these default values does fix, which looks like a bug of Vivado. I think it's good and ready to go now!

@stnolting
Copy link
Owner

Thanks for the feedback!

@stnolting stnolting merged commit e2f4d6f into stnolting:main Oct 19, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants