Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[vivado ip] hide entire AXI-Stream interface in block diagram if disabled #1058

Merged
merged 1 commit into from
Oct 14, 2024

Conversation

donlon
Copy link
Collaborator

@donlon donlon commented Oct 14, 2024

Currently empty ports for AXI-Stream interfaces (s1_axis and s0_axis) are still shown even if they're not enabled (shown in the picture). Setting enablement_dependency property for the bus interfaces instead can hide them entirely.

Tested in Vivado 2022.2

neorv-axis

…bled

Currently empty ports for AXI-Stream interfaces (s1_axis and s0_axis)
are still shown even if they're not enabled. Setting
enablement_dependency property for the bus interfaces instead can hide
them entirely.

Tested in Vivado 2022.2
@stnolting
Copy link
Owner

Hey @donlon!

Setting enablement_dependency property for the bus interfaces instead can hide them entirely.

That's great! I was not aware of this property.

So we could also use this approach to make the AXI4-MM optional, right?

@stnolting stnolting added enhancement New feature or request HW Hardware-related labels Oct 14, 2024
@stnolting stnolting merged commit 636cd6e into stnolting:main Oct 14, 2024
4 checks passed
@donlon
Copy link
Collaborator Author

donlon commented Oct 15, 2024

So we could also use this approach to make the AXI4-MM optional, right?

Yeah it does. We can use the same approach to make it more neat. (And I just found out that the external bus is optional even though I have used the core for a while.)

I'm also trying to reorganize the layout of the IP GUI and maybe will open another PR for them later :)

@donlon donlon deleted the vivado-bd-intf branch October 18, 2024 13:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request HW Hardware-related
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants