[sw/lib] restore previous registers in neorv32_xirq_get_num function to avoid side effects #1057
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
neorv32_xirq_get_num didn't restore previous CSR_MIE and NEORV32_XIRQ->EIE register and could cause unexpected side effect. So we save them before writing test bits and then restore them finally.
|
Good point - thanks for the update! |
stnolting
approved these changes
Oct 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
The
neorv32_xirq_get_numfunction didn't restore previousCSR_MIEandNEORV32_XIRQ->EIEregister and could cause unexpected side effects. So these registers are now saved before writing test bits and then restored finally.