Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[rtl] fix generate spelling #1031

Merged
merged 1 commit into from
Sep 24, 2024
Merged

Conversation

NikLeberg
Copy link
Collaborator

Just a little something.

BTW: I'm assuming the generate(s) with true value are for better visibility and partitioning when viewing the hierarchy in simulators etc. Is there a specific reason why you didnt use VHDL standard blocks? E.g.:

-- **************************************************************************************************************************
-- Clock and Reset Generators
-- **************************************************************************************************************************
generators: block
begin

-- Reset Sequencer ------------------------------------------------------------------------
-- -------------------------------------------------------------------------------------------
neorv32_sys_reset_inst: entity neorv32.neorv32_sys_reset
port map (
  clk_i      => clk_i,
  rstn_ext_i => rstn_i,
  rstn_wdt_i => rstn_wdt,
  rstn_dbg_i => dci_ndmrstn,
  rstn_ext_o => rstn_ext,
  rstn_sys_o => rstn_sys
);

-- <...>

end block generators;

BTW: Is there a specific reason you use

@stnolting
Copy link
Owner

stnolting commented Sep 24, 2024

I'm assuming the generate(s) with true value are for better visibility and partitioning when viewing the hierarchy in simulators etc.

Right.

Is there a specific reason why you didnt use VHDL standard blocks? E.g.:

That's a very good question... I also realized that I never ever use the with select construct... Maybe I just don't like the way they look 🤣 I don't know.

Anyway, the block does not require VHDL2008, right?

Furthermore, I think that the block statement can only be used to "encapsulate" concurrent statements, correct? So processes won't work there?!

@stnolting stnolting merged commit cec1946 into stnolting:main Sep 24, 2024
7 checks passed
@NikLeberg NikLeberg deleted the top/spelling branch September 24, 2024 22:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants