Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

minor fixes in OCD #1006

Merged
merged 2 commits into from
Sep 7, 2024
Merged

minor fixes in OCD #1006

merged 2 commits into from
Sep 7, 2024

Conversation

NikLeberg
Copy link
Collaborator

This proposes some minor fixes (no impact expected) of the OCD.

  • fix address map in linker script (not really important, but just for completeness)
  • fix renaming of dm_base_c to base_io_dm_c

As I don't think the changes will have any impact, I left out the CHANGELOG.md update. Let me know if you'd like to have one nonetheless.

@stnolting
Copy link
Owner

This looks great - thank you very much!

fix address map in linker script (not really important, but just for completeness)

Luckily the code only uses indirect jumps, otherwise it would have been a real bug. 🙈

As I don't think the changes will have any impact, I left out the CHANGELOG.md update. Let me know if you'd like to have one nonetheless.

👍

@stnolting stnolting merged commit 598f349 into stnolting:main Sep 7, 2024
7 checks passed
@NikLeberg NikLeberg deleted the fix/debug_rom_ld branch September 7, 2024 13:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stnolting stnolting stnolting approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@NikLeberg @stnolting