Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

User Guide - 1.3. Installation / Wrong export Statement #257

Closed
befedo opened this issue Jan 23, 2022 · 3 comments · Fixed by #258
Closed

User Guide - 1.3. Installation / Wrong export Statement #257

befedo opened this issue Jan 23, 2022 · 3 comments · Fixed by #258

Comments

@befedo
Copy link
Contributor

befedo commented Jan 23, 2022

Describe the bug
The user guide chapter 1.3. installation has a wrong export statement for the PATH variable.

To Reproduce

$ export PATH:$PATH:/opt/riscv/bin
bash: export: `PATH:/usr/local/bin:/usr/bin:/usr/local/sbin:/opt/riscv/bin': not a valid identifier

Expected behavior

$ export PATH=$PATH:/opt/riscv/bin && echo ${PATH}
/usr/local/bin:/usr/bin:/usr/local/sbin:/opt/riscv/bin

Replace first : with =.

Environment:

$ bash --version
bash --version
GNU bash, version 5.1.16(1)-release (x86_64-pc-linux-gnu)
Copyright (C) 2020 Free Software Foundation, Inc.
License GPLv3+: GNU GPL version 3 or later <http://gnu.org/licenses/gpl.html>

This is free software; you are free to change and redistribute it.
There is NO WARRANTY, to the extent permitted by law.

Can anyone confirm this or is something in my setup wrong?

Best Regards,
Befedo

@umarcor
Copy link
Collaborator

umarcor commented Jan 23, 2022

I can confirm that the fix looks good. Do you want to submit a PR? The file to be fixed is https://github.com/stnolting/neorv32/blob/master/docs/userguide/sw_toolchain_setup.adoc#13-installation.

befedo added a commit to befedo/neorv32 that referenced this issue Jan 23, 2022
fix(doc): Closes stnolting#257 and changes `export PATH:$PATH:/opt/riscv/bin` to
`export PATH=$PATH:/opt/riscv/bin`.
@befedo
Copy link
Contributor Author

befedo commented Jan 23, 2022

Hello @umarcor,

I've added the pull request #258 if it can be merged we can close this issue.

Thanks for your time and best regards,
Befedo

@stnolting
Copy link
Owner

Thanks for fixing!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants