Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added RAK3172T Variant #2431

Merged
merged 1 commit into from
Jul 15, 2024
Merged

Added RAK3172T Variant #2431

merged 1 commit into from
Jul 15, 2024

Conversation

nmaas87
Copy link
Contributor

@nmaas87 nmaas87 commented Jul 10, 2024

Summary

Adding Support for RAK3217T, should close #2162 and stm32duino/STM32LoRaWAN#34 - RAK3217 was already available, RAK3217T uses a TCXO which needed to be enabled in the variant files so that examples with STM32LoRaWAN works.

This PR fixes/implements the following bugs/features

Explain the motivation for making this change. What existing problem does the pull request solve?

Needed to use the RAK3172T myself and wanted the support to be available to all users.

Validation

  • LoRaWAN example from STM32LoRaWAN works and I can successfully connect to my gateway. Without the change, the TCXO is not used and the radio does not work correctly / cannot receive anything.

@fpistm fpistm added the new variant Add support of new bard label Jul 15, 2024
@fpistm fpistm added this to In progress in STM32 core based on ST HAL via automation Jul 15, 2024
Same as RAK3172 except TCXO is enabled.

Signed-off-by: Nico Maas <[email protected]>
Co-Authored-by: Frederic Pillon <[email protected]>
@fpistm
Copy link
Member

fpistm commented Jul 15, 2024

Hi @nmaas87
Thanks for the PR, I've simplified it using the same variant_. files as only TCXO value is different.

@fpistm fpistm added this to the 2.8.1 milestone Jul 15, 2024
Copy link
Member

@fpistm fpistm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

STM32 core based on ST HAL automation moved this from In progress to Reviewer approved Jul 15, 2024
@fpistm fpistm mentioned this pull request Jul 15, 2024
76 tasks
@fpistm fpistm merged commit 1e28f60 into stm32duino:main Jul 15, 2024
24 checks passed
STM32 core based on ST HAL automation moved this from Reviewer approved to Done Jul 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new variant Add support of new bard
Projects
Development

Successfully merging this pull request may close these issues.

[New Variant] Support for RAK3271T
2 participants