Enable IWDG module for Nucleo-64 F446RE board. by ghent360 · Pull Request #234 · stm32duino/Arduino_Core_STM32

ghent360 · 2018-04-02T08:18:20Z

Not sure why it was not enabled in the first place. It would probably work fine for other boards
as well.

enabled in the first place. It would probably work fine for other boards as well.

fpistm · 2018-04-03T07:40:47Z

Hi, @ghent360
There is no specific reason.
At the beginning we targetted to be Arduino Uno "like", so only basic feature was enabled, I guess.
User can enable HAL module, modifying the hal conf, or more simply adding a build_opt.h file at sketch level with -DHAL_IWDG_MODULE_ENABLED
Anyway, I see no reason to enable it by default.

In general, it could be interesting to provide small Arduino API like to to use dedicated feature.

ghent360 · 2018-04-03T08:05:22Z

Hi, @fpistm
Thank you for the consideration. Yes the build_opt.h file does work.
How does this look for an API start:

https://github.com/ghent360/Marlin/blob/bugfix-2.0.x/Marlin/src/HAL/HAL_STM32F4/watchdog_STM32F4.h

Or would you rather have Arduino style C++ API?

Watchdog.begin(uint16_t reload_time /* seconds */); // starts the watchdog
Watchdog.reload(); // call periodically to reload and prevent reset

fpistm · 2018-04-03T09:07:40Z

welcome. It's an community project. Any contribution are welcome. ;)
About API, it's open. C or C++ are welcome. I think the goal is to have something generic and user friendly.
Probably, C++ is not required to avoid use an instance or maybe both could be proposed...
C++ one using the C API?
Do not hesitate to propose one, why not based on Marlin one.

ghent360 · 2018-04-04T07:46:24Z

I reverted the HAL config change since the build_opt.h file can serve the same purpose. I added a Watchdog library and an example to expose the IWDG component.

ghent360 · 2018-04-06T04:52:58Z

@fpistm any thoughts on the API proposal?

fpistm · 2018-04-06T05:05:37Z

Hi @ghent360,
first look seems fine.
I will deeper review it in the coming weeks. Currently, I'm reviewing/testing RTC and Low Power which is a huge task ;)

…TM32 into pr-vefremov-1

Signed-off-by: Frederic.Pillon <frederic.pillon@st.com>

To skip use of those cache, define 'UNUSED_ID_CACHE' Signed-off-by: Frederic.Pillon <frederic.pillon@st.com>

day and mask pointers arguments of RTC_GetAlarm() could be NULL Fix unused variable warning Signed-off-by: Frederic.Pillon <frederic.pillon@st.com>

…TM32 into pr-vefremov-1

fpistm · 2018-06-13T05:08:14Z

I need to do more tests before release it so I will not have time to validate it properly for 1.3.0. This will be part of the 1.3.1

…TM32 into pr-vefremov-1

fpistm · 2018-07-31T13:18:32Z

I've reviewed this PR and done tests across several STM32 Series.
Basically, it works for series which do not have Window feature on those having this not worked.
Library format is not fully respected: src/ folder, library version have to be semver x.y.z.
I will rename it IWatchdog to differentiate with WWDG (when implemented).
New API could be added to know if the system has resumed from IWDG reset.
And probably handle also reset < 1ms (handle prescaler value 4/8/16) even if LSI accuracy is not very good. (I remember it is possible to use a timer connected to LSI to measure LSI freq but this could/will be an other enhancement, primary goal of this PR is to provide IWDG access :))
Also use LSI_VALUE typical value to define the best combo prescaler/reload value (example for F1, LSI is 40KHz).
Maybe using C++ could be fine to handle default method parameters and also using LL.
I need to think about all of this to handle it in the best way.
Any suggestions are welcome.

…TM32 into pr-vefremov-1

fpistm

#292 will replace this PR

…TM32 into pr-vefremov-1

fpistm · 2018-08-07T07:06:09Z

#292 merged. This one can be closed.
Thanks @ghent360

Commit reference: 4a02bfc ("Merge pull request stm32duino#234 from pillo79/license_cleanup", 2024-06-17) Signed-off-by: Frederic Pillon <frederic.pillon@st.com>

Enable IWDG module for Nucleo-64 F446RE board. Not sure why it was not

245e5be

enabled in the first place. It would probably work fine for other boards as well.

ghent360 added 2 commits April 4, 2018 00:36

Revert the HAL modification.

f5ca1bc

Add Watchdog library to expose the IWDG component.

ac814fe

fpistm added enhancement New feature or request New feature labels Apr 6, 2018

fpistm self-requested a review April 6, 2018 05:05

ghent360 and others added 10 commits April 9, 2018 20:37

Merge branch 'master' of https://github.com/stm32duino/Arduino_Core_S…

0b67ea7

…TM32 into pr-vefremov-1

Merge branch 'master' of https://github.com/stm32duino/Arduino_Core_S…

5e89c28

…TM32 into pr-vefremov-1

Merge branch 'master' of https://github.com/stm32duino/Arduino_Core_S…

0e3471a

…TM32 into pr-vefremov-1

Merge branch 'master' of https://github.com/stm32duino/Arduino_Core_S…

4e1e865

…TM32 into pr-vefremov-1

Merge branch 'master' of https://github.com/stm32duino/Arduino_Core_S…

c337725

…TM32 into pr-vefremov-1

Merge branch 'master' of https://github.com/stm32duino/Arduino_Core_S…

446c9d4

…TM32 into pr-vefremov-1

[DISCO_F746NG] Use HSE instead of HSE ByPass

fa7b449

Signed-off-by: Frederic.Pillon <frederic.pillon@st.com>

[CM7] Enable I-Cache and D-Cache

a71ed8d

To skip use of those cache, define 'UNUSED_ID_CACHE' Signed-off-by: Frederic.Pillon <frederic.pillon@st.com>

[RTC] Make some arguments optional (part 2)

1ff1e3e

day and mask pointers arguments of RTC_GetAlarm() could be NULL Fix unused variable warning Signed-off-by: Frederic.Pillon <frederic.pillon@st.com>

Merge branch 'master' of https://github.com/stm32duino/Arduino_Core_S…

fb628c3

…TM32 into pr-vefremov-1

fpistm force-pushed the master branch 2 times, most recently from 5f641c5 to cf54e13 Compare May 12, 2018 16:06

ghent360 added 4 commits May 13, 2018 01:14

Merge branch 'master' of https://github.com/stm32duino/Arduino_Core_S…

fa0dbfa

…TM32 into pr-vefremov-1

Merge branch 'master' of https://github.com/stm32duino/Arduino_Core_S…

28c63c3

…TM32 into pr-vefremov-1

Merge branch 'master' of https://github.com/stm32duino/Arduino_Core_S…

cd7bdc9

…TM32 into pr-vefremov-1

Merge branch 'master' of https://github.com/stm32duino/Arduino_Core_S…

e84adb3

…TM32 into pr-vefremov-1

fpistm added this to the 1.2.1/1.3.0 milestone May 28, 2018

Merge branch 'master' of https://github.com/stm32duino/Arduino_Core_S…

4d40743

…TM32 into pr-vefremov-1

Merge branch 'master' of https://github.com/stm32duino/Arduino_Core_S…

f61f749

…TM32 into pr-vefremov-1

fpistm added the review on going label Jun 2, 2018

Merge branch 'master' of https://github.com/stm32duino/Arduino_Core_S…

7d30e34

…TM32 into pr-vefremov-1

fpistm removed the review on going label Jun 13, 2018

fpistm modified the milestones: 1.3.0, 1.3.1 Jun 13, 2018

ghent360 added 5 commits June 13, 2018 02:15

Merge branch 'master' of https://github.com/stm32duino/Arduino_Core_S…

826a7f9

…TM32 into pr-vefremov-1

Merge branch 'master' of https://github.com/stm32duino/Arduino_Core_S…

11a2c44

…TM32 into pr-vefremov-1

Merge branch 'master' of https://github.com/stm32duino/Arduino_Core_S…

b50097b

…TM32 into pr-vefremov-1

Merge branch 'master' of https://github.com/stm32duino/Arduino_Core_S…

c044cf4

…TM32 into pr-vefremov-1

Merge branch 'master' of https://github.com/stm32duino/Arduino_Core_S…

d85964a

…TM32 into pr-vefremov-1

fpistm mentioned this pull request Jul 29, 2018

Add RemRam v1 board variant #287

Merged

Merge branch 'master' of https://github.com/stm32duino/Arduino_Core_S…

011c80c

…TM32 into pr-vefremov-1

ghent360 added 2 commits August 1, 2018 02:10

Merge branch 'master' of https://github.com/stm32duino/Arduino_Core_S…

00c3dbe

…TM32 into pr-vefremov-1

Merge branch 'master' of https://github.com/stm32duino/Arduino_Core_S…

8e02dd9

…TM32 into pr-vefremov-1

fpistm mentioned this pull request Aug 3, 2018

Add built-in IWatchdog library to expose the IWDG component. #292

Merged

fpistm reviewed Aug 3, 2018

View reviewed changes

ghent360 added 2 commits August 5, 2018 02:47

Merge branch 'master' of https://github.com/stm32duino/Arduino_Core_S…

32ad156

…TM32 into pr-vefremov-1

Merge branch 'master' of https://github.com/stm32duino/Arduino_Core_S…

fd648e3

…TM32 into pr-vefremov-1

fpistm closed this Aug 7, 2018

RickKimball mentioned this pull request Jun 2, 2019

how to use watchdog timer (iwdg) for blue pill STM32F103C8 #533

Closed

fpistm removed the New feature label Jul 16, 2024

fpistm added a commit to fpistm/Arduino_Core_STM32 that referenced this pull request Nov 19, 2025

feat: add ArduinoCore-API

1da6e00

Commit reference: 4a02bfc ("Merge pull request stm32duino#234 from pillo79/license_cleanup", 2024-06-17) Signed-off-by: Frederic Pillon <frederic.pillon@st.com>

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Enable IWDG module for Nucleo-64 F446RE board.#234

Enable IWDG module for Nucleo-64 F446RE board.#234
ghent360 wants to merge 30 commits intostm32duino:masterfrom
ghent360:pr-vefremov-1

ghent360 commented Apr 2, 2018

Uh oh!

fpistm commented Apr 3, 2018 •

edited

Loading

Uh oh!

ghent360 commented Apr 3, 2018

Uh oh!

fpistm commented Apr 3, 2018

Uh oh!

ghent360 commented Apr 4, 2018

Uh oh!

ghent360 commented Apr 6, 2018

Uh oh!

fpistm commented Apr 6, 2018

Uh oh!

fpistm commented Jun 13, 2018

Uh oh!

fpistm commented Jul 31, 2018

Uh oh!

fpistm left a comment

Uh oh!

fpistm commented Aug 7, 2018

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Conversation

ghent360 commented Apr 2, 2018

Uh oh!

fpistm commented Apr 3, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

ghent360 commented Apr 3, 2018

Uh oh!

fpistm commented Apr 3, 2018

Uh oh!

ghent360 commented Apr 4, 2018

Uh oh!

ghent360 commented Apr 6, 2018

Uh oh!

fpistm commented Apr 6, 2018

Uh oh!

fpistm commented Jun 13, 2018

Uh oh!

fpistm commented Jul 31, 2018

Uh oh!

fpistm left a comment

Choose a reason for hiding this comment

Uh oh!

fpistm commented Aug 7, 2018

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

fpistm commented Apr 3, 2018 •

edited

Loading