Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added F410T(8-B)Y board #1791

Merged
merged 6 commits into from
Aug 30, 2022
Merged

Added F410T(8-B)Y board #1791

merged 6 commits into from
Aug 30, 2022

Conversation

alextrical
Copy link
Contributor

Added F410T(8-B)Y board

Testing how to use Branches for development work

ABOSTM
ABOSTM reviewed Aug 11, 2022
View reviewed changes
Copy link
Contributor

@ABOSTM ABOSTM left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just to be sure we are aligned, when I said 1 PR per series, I mean 1 for all STM43F4 MCU.
But I understand that you are experimenting.
Otherwise, this PR LGTM :-)

@fpistm fpistm added the new variant Add support of new bard label Aug 11, 2022
@fpistm fpistm added this to the 2.3.1/2.4.0 milestone Aug 11, 2022
fpistm
fpistm requested changes Aug 11, 2022
View reviewed changes
README.md Outdated Show resolved Hide resolved
variants/STM32F4xx/F410T(8-B)Y/generic_clock.c Outdated Show resolved Hide resolved
alextrical and others added 2 commits August 11, 2022 10:51
@alextrical
Copy link
Contributor Author

Just to be sure we are aligned, when I said 1 PR per series, I mean 1 for all STM43F4 MCU.

Correct, I just started using the smallest group I had ;)

@alextrical alextrical requested a review from fpistm August 11, 2022 10:00
@alextrical alextrical requested a review from ABOSTM August 11, 2022 17:34
ABOSTM
ABOSTM approved these changes Aug 12, 2022
View reviewed changes
Copy link
Contributor

@ABOSTM ABOSTM left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@fpistm
Copy link
Member

fpistm commented Aug 30, 2022

Hi @alextrical
Thanks for the update anyway, a merge is not a rebase and provides artifact which should not appears in a PR.
Due to the merge you pull also several commit already available in the main.

fpistm
fpistm approved these changes Aug 30, 2022
View reviewed changes
Copy link
Member

@fpistm fpistm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@fpistm fpistm merged commit aea5d0e into stm32duino:main Aug 30, 2022
cparata pushed a commit to cparata/Arduino_Core_STM32 that referenced this pull request Jan 31, 2023
@alextrical @fpistm @cparata
variant: add F410T(8-B)Y board (stm32duino#1791)
3adb73f 
* Added F410T(8-B)Y board

* Update README.md

Co-authored-by: Frederic Pillon <[email protected]>

* Style corrections

* Corrected ldscript.ld names

* Fixed issue caused by incorrect RegEx query, removing parenthesis

Co-authored-by: Frederic Pillon <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ABOSTM ABOSTM ABOSTM approved these changes

@fpistm fpistm fpistm approved these changes

Assignees
No one assigned
Labels
new variant Add support of new bard
Projects
None yet
Milestone
2.4.0
Development

Successfully merging this pull request may close these issues.
3 participants
@alextrical @fpistm @ABOSTM