Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HardwareTimer: call refresh() after parameter update when timer not running #1721

Merged

Conversation

ABOSTM
Copy link
Contributor

@ABOSTM ABOSTM commented May 18, 2022

Summary
HardwareTimer: call refresh() after parameter update when timer not running

In case timer is not running,
after an update of parameters (setOverflow(), setCaptureCompare(), setPrescaleFactor()),
call refresh() to force register update independently of Preload setting.

Fixes https://www.stm32duino.com/viewtopic.php?f=7&t=1563

…unning

In case timer is not running,
after an update of parameters (setOverflow(), setCaptureCompare(),
setPrescaleFactor()),
call refresh() to force register update independently of Preload setting.

Fixes https://www.stm32duino.com/viewtopic.php?f=7&t=1563

Signed-off-by: Alexandre Bourdiol <[email protected]>
@ABOSTM ABOSTM requested a review from fpistm May 18, 2022 15:39
@fpistm fpistm added the enhancement New feature or request label May 18, 2022
@fpistm fpistm added this to the 2.3.0 milestone May 18, 2022
Copy link
Member

@fpistm fpistm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@fpistm fpistm merged commit f8bf924 into stm32duino:main May 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants