Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WB enhancements #1291

Merged
merged 5 commits into from
Feb 4, 2021
Merged

WB enhancements #1291

merged 5 commits into from
Feb 4, 2021

Conversation

fpistm
Copy link
Member

@fpistm fpistm commented Feb 2, 2021 •
edited
Loading

  • Remove OTP API from the variant and provide it as a bsp.
  • Enable HSEM HAL module by default
  • Move HSE Capacitor Tuning api to clock api file
  • Add required semaphore managements

Supersede #1290

@fpistm fpistm requested review from FRASTM and ABOSTM February 2, 2021 15:36
@fpistm fpistm added enhancement New feature or request fix 🩹 Bug fix labels Feb 2, 2021
@fpistm fpistm added this to the 2.0.0 milestone Feb 2, 2021
@fpistm fpistm mentioned this pull request Feb 2, 2021
Closed
ABOSTM
ABOSTM reviewed Feb 2, 2021
View reviewed changes
Copy link
Contributor

@ABOSTM ABOSTM left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, minor question ?

libraries/SrcWrapper/src/stm32/clock.c Show resolved Hide resolved
@fpistm
Copy link
Member Author

fpistm commented Feb 2, 2021

@ABOSTM
note that the PR is no ended.

@fpistm fpistm mentioned this pull request Feb 2, 2021
Merged
@fpistm fpistm marked this pull request as draft February 3, 2021 14:58
@fpistm fpistm requested a review from ABOSTM February 3, 2021 14:58
ABOSTM
ABOSTM suggested changes Feb 3, 2021
View reviewed changes
cores/arduino/stm32/lock_resource.h Outdated Show resolved Hide resolved
cores/arduino/stm32/lock_resource.h Outdated Show resolved Hide resolved
variants/PNUCLEO_WB55RG/variant.cpp Outdated Show resolved Hide resolved
@fpistm fpistm force-pushed the WB_fix branch 2 times, most recently from 93bc407 to ca753ac Compare February 3, 2021 17:12
@FRASTM FRASTM mentioned this pull request Feb 4, 2021
Merged
@fpistm fpistm requested a review from ABOSTM February 4, 2021 10:33
ABOSTM
ABOSTM suggested changes Feb 4, 2021
View reviewed changes
Copy link
Contributor

@ABOSTM ABOSTM left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think HSEM is necessary in analog.cpp when calling
__HAL_RCC_ADC_CONFIG()

@fpistm
Copy link
Member Author

fpistm commented Feb 4, 2021

I think HSEM is necessary in analog.cpp when calling
__HAL_RCC_ADC_CONFIG()

Right nice catch 👍

@fpistm
Rework hardware semaphore usage
5bc2384 
This new implementation is mroe generic and support MP1 as well WB.
H7 could be added easily later if dual core support is implemented.

Signed-off-by: Frederic Pillon <[email protected]>
@fpistm
[WB] Add hardware semaphore management for RCC
89e2f09 
WB serie will require more semaphore management for
low power and flash.

Signed-off-by: Frederic Pillon <[email protected]>
@fpistm fpistm requested a review from ABOSTM February 4, 2021 13:45
@fpistm fpistm marked this pull request as ready for review February 4, 2021 16:06
ABOSTM
ABOSTM approved these changes Feb 4, 2021
View reviewed changes
Copy link
Contributor

@ABOSTM ABOSTM left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@fpistm fpistm merged commit 82cdead into stm32duino:master Feb 4, 2021
@fpistm fpistm deleted the WB_fix branch February 4, 2021 18:06
@fpistm fpistm mentioned this pull request Jun 6, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FRASTM FRASTM FRASTM approved these changes

@ABOSTM ABOSTM ABOSTM approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request fix 🩹 Bug fix
Projects
None yet
Milestone
2.0.0
Development

Successfully merging this pull request may close these issues.
3 participants
@fpistm @ABOSTM @FRASTM