Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Leafony STM32 #1887

Closed
masa6372 opened this issue Dec 2, 2022 · 6 comments · Fixed by #1889
Closed

Leafony STM32 #1887

masa6372 opened this issue Dec 2, 2022 · 6 comments · Fixed by #1889
Labels
new variant Add support of new bard

Comments

@masa6372
Copy link

masa6372 commented Dec 2, 2022

@masa6372 masa6372 added the new variant Add support of new bard label Dec 2, 2022
@fpistm fpistm mentioned this issue Dec 5, 2022
83 tasks
@fpistm
Copy link
Member

fpistm commented Dec 5, 2022

Related to https://www.stm32duino.com/viewtopic.php?t=1785

Added to [New Variant] request list #722
Feel free to contribute and submit PR to add it.
To add a STM32 based board follows this wiki

@fpistm fpistm closed this as completed Dec 5, 2022
@masa6372
Copy link
Author

masa6372 commented Dec 6, 2022

Hi, I'm wondering how to add a variant. Does it automatically created, or do we have to create it by following the wiki?

@fpistm
Copy link
Member

fpistm commented Dec 6, 2022

Some files already exists:
https://github.com/stm32duino/Arduino_Core_STM32/tree/main/variants/STM32L4xx/L452RC(I-T-Y)_L452RE(I-T-Y)x(P)_L462RE(I-T-Y)
You have to add your own variant_. which describe your board then declare it to the boards.txt.
If you can start to define the pin mapping and I will try to help you to finish the variant.

@masa6372
Copy link
Author

masa6372 commented Dec 6, 2022

Thanks!
I've added variant_LEAFONY_STM32.cpp and variant_LEAFONY_STM32.h.
https://github.com/Leafony/Arduino_Core_STM32/tree/main/variants/STM32L4xx/Leafony_STM32

Can you tell me where to modify?

@fpistm fpistm reopened this Dec 6, 2022
fpistm added a commit to fpistm/Arduino_Core_STM32 that referenced this issue Dec 6, 2022
Fixes stm32duino#1887

Signed-off-by: Frederic Pillon <[email protected]>
@fpistm
Copy link
Member

fpistm commented Dec 6, 2022

@masa6372
I've made the variant update:
#1889

Please, Could you review and test it?

@masa6372
Copy link
Author

masa6372 commented Dec 8, 2022

LGTM!

fpistm added a commit that referenced this issue Dec 8, 2022
Fixes #1887

Signed-off-by: Frederic Pillon <[email protected]>
cparata pushed a commit to cparata/Arduino_Core_STM32 that referenced this issue Jan 31, 2023
Fixes stm32duino#1887

Signed-off-by: Frederic Pillon <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new variant Add support of new bard
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants