Add channel impls for pins PE9 and PE10 when using stm32f303xe feature #345
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dpralas
changed the title
Sh3Rm4n
requested changes
Nov 23, 2023
There was a problem hiding this comment.
Those pin impls are auto generated by tools/adc_channels.py, which is pretty ugly and should be refactored. I'm working on a refactor, so until this is not done your change is fine!
Please add a changelog entry and this PR is good to go (also a rebase is needed fixing the compiler issues in CI)
Sh3Rm4n
approved these changes
Nov 24, 2023
|
Thanks, much appreciated. I'll hope to release a new version soon. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #344.