Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement serial::{Tx,Rx}::{listen,unlisten}. #72

Merged
merged 1 commit into from
Jun 11, 2019

Conversation

jmgao
Copy link
Contributor

@jmgao jmgao commented Jun 11, 2019

This PR adds listen and unlisten to Tx and Rx, acting identically to Serial::listen/unlisten(Txe/Rxne).

(I'm not super happy with the duplication here, but it didn't seem trivial to extract it to a helper. Let me know if you want me to do so.)

@jmgao
Copy link
Contributor Author

jmgao commented Jun 11, 2019

(build failure seems bogus)

$ rustup target add thumbv7m-none-eabi
info: downloading component 'rust-std' for 'thumbv7m-none-eabi'
error: component download failed for rust-std-thumbv7m-none-eabi
info: caused by: could not download file from 'https://static.rust-lang.org/dist/2019-05-23/rust-std-1.35.0-thumbv7m-none-eabi.tar.xz' to '/home/travis/.rustup/downloads/efbf39a10565886cab20a6278dd51702717ae4ca8de27cac7b937fff5d3f4ed7.partial'
info: caused by: failed to make network request
info: caused by: https://static.rust-lang.org/dist/2019-05-23/rust-std-1.35.0-thumbv7m-none-eabi.tar.xz: timed out

@TheZoq2
Copy link
Member

TheZoq2 commented Jun 11, 2019

Thanks for the PR, the failure does seems to be caused by travis.

That amount of duplication is no problem in my opinion, it's pretty much unavoidable.

Would you mind adding a changelog entry for this?

@jmgao
Copy link
Contributor Author

jmgao commented Jun 11, 2019

Done.

@TheZoq2
Copy link
Member

TheZoq2 commented Jun 11, 2019

Perfect, thanks!

@TheZoq2 TheZoq2 merged commit 42bb6ec into stm32-rs:master Jun 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants