Remove wfi in examples #450
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes
wfifrom examples. I ran into an issue flashing code onto my board after flashing one of the examples and found this thread which finally gave me the method I needed to erase the code flash.Since these are examples and power consumption is not a big deal, I think it's not necessary to use
wfiand instead just let the microcontroller processor spin. Seems better than pushing someone through some general headache around the board no longer being connectable via SWD. I did leave it as-is inexamples/timer-interrupt-rtic.rsas I'm less certain of it's necessity in an RTIC context.