Fix computation of timer frequency #434
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Retrieving timer frequency using PwmHz::get_period() function can cause division by zero exception for certain types of frequencies which are configured by having zero in any of the PSC or ARR register - current implementation uses "clk / (psc * arr)" expression to compute the frequency. Implementation of compute_arr_presc() sets PSC and ARR registers correctly. Performing inverse computation leads to different expression: "clk / ((psc + 1) * (arr + 1))" which properly computes timer frequency from PSC and ARR registers. This patch uses new/fixed expression for computing timer frequency.
burrbull
approved these changes
Aug 26, 2022
|
bors r+ |
bors bot
added a commit
to stm32-rs/stm32f4xx-hal
that referenced
this pull request
Aug 26, 2022
518: fix PwmHz::get_period r=therealprof a=burrbull See stm32-rs/stm32f1xx-hal#434 Co-authored-by: Andrey Zgarbul <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Retrieving timer frequency using PwmHz::get_period() function can cause
division by zero exception for certain types of frequencies which are
configured by having zero in any of the PSC or ARR register - current
implementation uses "clk / (psc * arr)" expression to compute the
frequency.
Implementation of compute_arr_presc() sets PSC and ARR registers
correctly. Performing inverse computation leads to different expression:
"clk / ((psc + 1) * (arr + 1))" which properly computes timer frequency
from PSC and ARR registers. This patch uses new/fixed expression for
computing timer frequency.
Change log was modified.