Add support for reconfiguring a Serial port #385
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM. |
horazont
force-pushed
the
feature/serial-change-config
branch
from
0da1409
to
11410eb
Compare
Example use case is to implement a 1-Wire Bus "Master" [1]. In that example, the UART is used instead of bit-banging the 1-Wire protocol. However, not all signals can be generated with a single baud rate. In particular, the 1-wire reset strobe is much longer than the 1-wire data strobes, requiring to use a different, slower baud rate to reset devices. [1]: https://www.maximintegrated.com/en/design/technical-documents/tutorials/2/214.html Signed-off-by: Jonas Schäfer <[email protected]>
horazont
force-pushed
the
feature/serial-change-config
branch
from
11410eb
to
65e63b2
Compare
|
@burrbull Thanks for the feedback. I fmt'd the code and added a simple example. A full UART-based 1-wire master would be quite complex and would fit more into a separate library. Tested it with the STM32VLDISCOVERY board (had to adapt memory.x and use breakpoints instead of asm::bkpt locally). |
burrbull
approved these changes
Jan 8, 2022
|
bors r+ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Example use case is to implement a 1-Wire Bus "Master". In that example, the UART is used instead of bit-banging the 1-Wire protocol. However, not all signals can be generated with a single baud rate. In particular, the 1-wire reset strobe is much longer than the 1-wire data strobes, requiring to use a different, slower baud rate to reset devices.