Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use modify instead of write #373

Merged
merged 1 commit into from
Nov 17, 2021
Merged

Use modify instead of write #373

merged 1 commit into from
Nov 17, 2021

Conversation

gnxlxnxx
Copy link
Contributor

@gnxlxnxx gnxlxnxx commented Nov 16, 2021 •
edited
Loading

If we use write here one can not use dma with tx and rx at the same time, as the second with_dma() overwrites the register

@burrbull
Copy link
Member

Do same in release methods.

@gnxlxnxx
Copy link
Contributor Author

ah, missed that

@TheZoq2
Copy link
Member

TheZoq2 commented Nov 17, 2021

LGTM, Thanks!

@TheZoq2 TheZoq2 merged commit e790b27 into stm32-rs:master Nov 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@burrbull burrbull burrbull approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@gnxlxnxx @burrbull @TheZoq2