-
Notifications
You must be signed in to change notification settings - Fork 179
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Do not enable UART DMA flags unconditionally #336
Do not enable UART DMA flags unconditionally #336
Conversation
dd9ef64
to
01635af
Compare
Updated as per #334 (comment). |
bd5e011
to
7040d39
Compare
Renamed serial-dma |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR! I pointed out a few mut
s which cause warnings, other than that I think this is ready to merge (possibly after testing on hw)
cc @TeXitoi |
@burrbull you want acces right to this repo? |
It would be great. |
I can't find how to add you to the stm32f1 team, looks like I don't have the right or I can't find the settings |
Previously only @therealprof was a maintainer for the stm32f1 team, but I've added you as well @TeXitoi, so you should be able to add new team members now. |
Thanks, @burrbull added. |
Thanks. |
Fixes #334
I have not tested that code, though, so proceed with caution :)