Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add example of GPIO input mode #316

Merged
merged 5 commits into from
Jul 14, 2021
Merged

Add example of GPIO input mode #316

merged 5 commits into from
Jul 14, 2021

Conversation

YuaXan
Copy link
Contributor

@YuaXan YuaXan commented Mar 5, 2021

I not found example about gpio input mode long time, so I written the example to share everyone.

@YuaXan YuaXan changed the title add example of gpio input Add example of GPIO input Mar 5, 2021
@YuaXan YuaXan changed the title Add example of GPIO input Add example of GPIO input mode Mar 5, 2021
@YuaXan
Copy link
Contributor Author

YuaXan commented Mar 11, 2021

Not guys come pull requests? @TheZoq2 @therealprof

@therealprof
Copy link
Member

@YuaXan Thanks for the PR! I think we could certainly use more examples. There're some things which need improving though to make it an educational resource:

  • More code comments
  • Spellcheck
  • Addition to the Cargo.toml

Also the manual re-implementation of the OutputPin (and other) traits is a bit unusual. Why not use type aliases instead to define your custom RedLedPin and GreenLedPin?

@YuaXan
Copy link
Contributor Author

YuaXan commented Mar 14, 2021

@therealprof Thanks for your tell me about my mistakes. I fixed these mistakes.

@burrbull
Copy link
Member

bors r+

@bors
Copy link
Contributor

bors bot commented Jul 14, 2021

@bors bors bot merged commit c8afe0d into stm32-rs:master Jul 14, 2021
@YuaXan
Copy link
Contributor Author

YuaXan commented Jul 14, 2021

@burrbull Thanks for merged my PR, This was my first contribution to opensource. I wish I will keep going. :D

@TheZoq2
Copy link
Member

TheZoq2 commented Jul 14, 2021

@YuaXan nice job on your first contribution! Sorry for ignoring this (and a bunch of other PRs) for so long, I hope that didn't put you off too much!

And thanks @burrbull for taking care of all the PRs which i have ignored ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants