Proposal for setting the IO Slew Rate #267
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the PR! I feel like it would be nice to have more descriptive names as slow/medium/fast could really be anything. I can't come up with a very good suggestion though Perhaps Also, would you mind adding a changelog entry? :) |
@TheZoq2 I wasn't sure what to do about the version number for the changelog entry. Any tips for something like this?
Yeah, I'll give it some thought and rename them |
|
@TheZoq2 okay, done |
|
Awesme, thanks. Changelog entry looks perfect as well! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #266 by adding an enumeration of IO speeds available and a single method trait that is implemented for Output pins as well as push-pull alternate function pins