Add missing SPI3 remap #265
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mitchmindtree
force-pushed
the
spi3-remap
branch
from
9d11931
to
cad68d6
Compare
|
Hmm, this is interesting. Is the spi3 completely unusable without remap? |
mitchmindtree
force-pushed
the
spi3-remap
branch
from
cad68d6
to
2b59b78
Compare
|
From memory yes, this allowed me to get it working at all, but I haven't had a chance to triple check this since your comment just yet. |
|
Oh, I looked into this in more detail and it makes a lot of sense that this would be needed now. Would you mind fixing the merge conflict in CHANGELOG.md? |
This is necessary in order for SPI3 to function correctly. Note that this is a breaking change, as it requires access to `MAPR` via a new argument. This has been added as the third argument to match the `spi1` constructor. Tested successfully on an F107.
mitchmindtree
force-pushed
the
spi3-remap
branch
from
2b59b78
to
c125a3a
Compare
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is necessary in order for SPI3 to function correctly.
Note that this is a breaking change, as it requires access to
MAPRviaa new argument. This has been added as the third argument to match the
spi1constructor.Tested successfully on an F107.