Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add building and fmt on travis #1

Closed
TeXitoi opened this issue Dec 13, 2018 · 9 comments
Closed

Add building and fmt on travis #1

TeXitoi opened this issue Dec 13, 2018 · 9 comments

Comments

@TeXitoi
Copy link
Contributor

TeXitoi commented Dec 13, 2018

To check that we compile on a set of different rust version, and that our formating is consistent, I propose to check on travis that the crate and its examples are building, and that our formating comply with rustfmt.

If it's OK, I can propose a PR for that.

@therealprof
Copy link
Member

@TeXitoi We will definitely have Travis CI (as we do for the other -hal crates in this organisation). It's not in at the moment due to the USB SNAFU which means it does not fully compile yet.

@TeXitoi
Copy link
Contributor Author

TeXitoi commented Dec 13, 2018

I don't get it, right now, Cargo.toml point to japaric's stm32f103xx crate, so it should compile, no?

@TeXitoi
Copy link
Contributor Author

TeXitoi commented Dec 13, 2018

@therealprof can you add an issue about this SNAFU problem with some explanations to be able to follow the works on this subject? Thanks.

@therealprof
Copy link
Member

@TeXitoi Please find it in #3 .

@TeXitoi
Copy link
Contributor Author

TeXitoi commented Dec 13, 2018

@therealprof thanks

@therealprof
Copy link
Member

therealprof commented Dec 13, 2018

@TeXitoi You're now a collaborator on this repository (I hope).

@TeXitoi
Copy link
Contributor Author

TeXitoi commented Dec 13, 2018

Yes, thanks to @adamgreig for the invitation on stm32-rs org!

@therealprof
Copy link
Member

I don't get it, right now, Cargo.toml point to japaric's stm32f103xx crate, so it should compile, no?

That's just a dev dependency and shouldn't even be there...

luctius pushed a commit to luctius/stm32f1xx-hal that referenced this issue Mar 16, 2020
@TheZoq2
Copy link
Member

TheZoq2 commented Apr 26, 2020

I think this can be closed now thanks to #208 and #207

@TheZoq2 TheZoq2 closed this as completed Apr 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants