Hubspot: v2.0 #7
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 6 commits
December 29, 2017 15:33
added 9 commits
May 11, 2018 15:20
As this was deprecated by HubSpot, it’s being removed from the tap/integration: https://integrate.hubspot.com/t/heads-up-sunsetting-the-keywords-api-in- 2018/8127
|
@KAllan357 Here's the rendered preview of the new docs. Take and let me know if anything can be improved :) Thanks! |
KAllan357
reviewed
May 11, 2018
|
|
||
| name: "companies" | ||
| doc-link: http://developers.hubspot.com/docs/methods/companies/get_company | ||
| singer-schema: https://github.com/singer-io/tap-hubspot/blob/master/tap_hubspot/schemas/companies.json | ||
| description: | | ||
| The `companies` table contains info about the companies your HubSpot contacts belong to. | ||
|
|
||
| **Note:** when this table is synced, the [`hubspot_contacts_by_company`](#hubspot_contacts_by_company) table will also be automatically synced and created in your data warehouse. | ||
| **Note:** When this table is set to replicate, the [`contacts_by_company`](#contacts_by_company) table will be automatically created in your data warehouse. |
There was a problem hiding this comment.
This is actually not true. We have table selection here so you can choose whether or not to sync this table.
There was a problem hiding this comment.
Oooh, this is great! Before this wasn't selectable in the UI. I'll make this change in just a sec, but then these docs are good to go.
|
Left a comment for one thing, but otherwise 👍 💯 🚀 🐎 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates the HubSpot documentation for version 2.x.
Release notes/version summary:
_integration-schemas/hubspot/foreign-keys.md) for version 2.x only.contactstable now uses theversionTimestampfield as a Replication Key (bookmark) (Syncs contacts based onversionTimestampsinger-io/tap-hubspot#58)contactstable now includes all submissions, not just the newest (Feature/grab all form submissions singer-io/tap-hubspot#61)contacts_by_companycan now be selected in the UI for replication (Add contacts by company field selection singer-io/tap-hubspot#63)keywordstable/stream was removed due to HubSpot deprecation (Remove keywords stream singer-io/tap-hubspot#68)counterevent fields added to thecampaignstable schema (Add additional counters to campaigns singer-io/tap-hubspot#69)isDeletedfields were removed fromcompaniesanddeals(Remove isDeleted from deals and companies because it is confusing singer-io/tap-hubspot#70)