Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: change clusterNodes back to nodes #1263

Merged
merged 4 commits into from
Mar 28, 2023
Merged

fix: change clusterNodes back to nodes #1263

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
0cfa078
fix: change clusterNodes back to nodes
egmzy Mar 28, 2023
a1ae2a1
fix: lint suggested to use dot notation
egmzy Mar 28, 2023
08d9cb0
fix name duplication between nodes method and variable
egmzy Mar 28, 2023
d968ea7
fix test to use nodes as a method
egmzy Mar 28, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -268,7 +268,7 @@ RedisMock.Cluster = class RedisClusterMock extends RedisMock {
`Invalid role "${role}". Expected "all", "master" or "slave"`
)
}
return this.clusterNodes['all'] // temporary return all until implemented slave and master logic
return this.clusterNodes.all // temporary return all until implemented slave and master logic
}
}

Expand Down
4 changes: 2 additions & 2 deletions test/integration/cluster.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,8 +11,8 @@ describe('cluster', () => {
const nodes = ['redis://localhost:7001', 'redis://localhost:7002']
const cluster = new Redis.Cluster(nodes)
expect(cluster.connected).toEqual(true)
expect(cluster.nodes.length).toEqual(nodes.length)
expect(cluster.nodes.every(node => node instanceof Redis)).toBeTruthy()
expect(cluster.nodes().length).toEqual(nodes.length)
expect(cluster.nodes().every(node => node instanceof Redis)).toBeTruthy()
})

it('can set and get', () => {
Expand Down