Skip to content

Commit

Permalink
fix(publish): channel is Buffer for messageBuffer event
Browse files Browse the repository at this point in the history
  • Loading branch information
erictheswift committed Jan 11, 2023
1 parent 346dad7 commit a8deeaa
Show file tree
Hide file tree
Showing 2 changed files with 7 additions and 13 deletions.
16 changes: 5 additions & 11 deletions src/commands-utils/emitMessage.js
Original file line number Diff line number Diff line change
@@ -1,18 +1,12 @@
export default function emitMessage(redisMock, channel, message, pattern) {
process.nextTick(() => {
const [patternEvent, regularEvent, channelToEmit] = Buffer.isBuffer(message)
? ['pmessageBuffer', 'messageBuffer', Buffer.from(channel)]
: ['pmessage', 'message', channel]
if (pattern) {
redisMock.emit(
Buffer.isBuffer(message) ? 'pmessageBuffer' : 'pmessage',
pattern,
channel,
message
)
redisMock.emit(patternEvent, pattern, channelToEmit, message)
} else {
redisMock.emit(
Buffer.isBuffer(message) ? 'messageBuffer' : 'message',
channel,
message
)
redisMock.emit(regularEvent, channelToEmit, message)
}
})
}
4 changes: 2 additions & 2 deletions test/integration/commands/publish.js
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,7 @@ runTwinSuite('publish', command => {
const redis2 = new Redis()
const buffer = Buffer.alloc(8)
redisPubSub.on('messageBuffer', (channel, message) => {
expect(channel).toBe('emails')
expect(channel).toEqual(Buffer.from('emails'))
expect(message).toBe(buffer)
redisPubSub.unsubscribe('emails')
done()
Expand Down Expand Up @@ -77,7 +77,7 @@ runTwinSuite('publish', command => {
const buffer = Buffer.alloc(0)
redisPubSub.on('pmessageBuffer', (pattern, channel, message) => {
expect(pattern).toBe('emails.*')
expect(channel).toBe('emails.urgent')
expect(channel).toEqual(Buffer.from('emails.urgent'))
expect(message).toBe(buffer)
redisPubSub.punsubscribe('emails.*')
done()
Expand Down

0 comments on commit a8deeaa

Please sign in to comment.