Add auto-fix for DropConsOfItemAndList #140
Conversation
| , schema = | ||
| Schema.schema | ||
| |> Schema.rangeProp "range" | ||
| |> Schema.rangeProp "car" | ||
| |> Schema.rangeProp "cdr" |
There was a problem hiding this comment.
Ah, those are Lisp-y terms that crept in. car and cdr are analogous to List.head and List.tail. I should probably use head and tail instead.
| fix : ( String, File ) -> MessageData -> Result String String | ||
| fix ( content, _ ) messageData = | ||
| case | ||
| ( Data.getRange "car" messageData |
There was a problem hiding this comment.
Use a Maybe.map2 (,) to compose the two Maybes into 1. Try to reduce the use of _ as much as possible
There was a problem hiding this comment.
Ah, that's much cleaner.
| fixContent carRange cdrRange content |> Ok | ||
|
|
||
| _ -> | ||
| Err "Invalid message data for fixer UnnecessaryParens" |
There was a problem hiding this comment.
'UnnecessaryParens': Message is copied from somewhere else. Please use the correct check name. (I've created an issue to fix this #141)
- Replace "car" and "cdr" with "head" and "tail" - Tidy up match expression - Fix copy-paste mistake in error message
|
I made a few changes. I think it's all set. |
| @@ -42,7 +44,7 @@ scan fileContext _ = | |||
| onExpression : Ranged Expression -> Context -> Context | |||
| onExpression ( r, inner ) context = | |||
| case inner of | |||
| OperatorApplication "::" _ _ ( _, ListExpr _ ) -> | |||
| OperatorApplication "::" _ ( carRange, _ ) ( cdrRange, ListExpr _ ) -> | |||
There was a problem hiding this comment.
Maybe rename these to headRange and tailRange.
There was a problem hiding this comment.
Oops, I thought I had gotten all of them.
|
All set |
Another box on #5
I also modified
FileContent.updateRangeto treat ranges as [inclusive, exclusive), which feels more natural - for example, if you use the end of one range as the start of another, then they don't overlap.