Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Improvement] LineLengthExceeded could display lines #103

Closed
andys8 opened this issue Aug 16, 2017 · 3 comments
Closed

[Improvement] LineLengthExceeded could display lines #103

andys8 opened this issue Aug 16, 2017 · 3 comments
Milestone

Comments

@andys8
Copy link
Contributor

andys8 commented Aug 16, 2017

I've a minor suggestion for the output message of LineLengthExceeded: Line numbers would be awesome 😃 It works as it is for small files but it takes quite a while in large Main files.

Line length exceeded on 1 line(s) in file "src/Main.elm".

Source

https://github.com/stil4m/elm-analyse/blob/master/src/Analyser/Messages/Util.elm#L467-L478

I think for duplicates it's already implemented to print ranges:
https://github.com/stil4m/elm-analyse/blob/master/src/Analyser/Messages/Util.elm#L315-L345

@stil4m
Copy link
Owner

stil4m commented Aug 16, 2017

Good point. I use elm-analyse mostly as UI (elm-analyse -s) and then I do not encounter this issue. I must keep a broader mind when I implement these things. 🤐

@stil4m
Copy link
Owner

stil4m commented Aug 17, 2017

@andys8 What about something like this:

Line length exceeded on line(s) [12,30] in file "docs/Docs/Configuration.elm".
Line length exceeded on line(s) [33,36,46,61,89,99,102,107] in file "docs/Docs/Features.elm".
Line length exceeded on line(s) [55,80,101] in file "docs/Docs/Home.elm".
Line length exceeded on line(s) [123,168,190,797] in file "docs/Docs/MsgDoc.elm".

@stil4m stil4m added this to the 0.12.0 milestone Aug 17, 2017
@andys8
Copy link
Contributor Author

andys8 commented Aug 17, 2017

Awesome 😃

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants