Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Load a preset called "Default" at power up if it is there #30

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

probonopd
Copy link

@probonopd probonopd commented Dec 10, 2016

When I power up my device I want to have it come up with a color... am I the only one?

@sticilface
Copy link
Owner

Thanks for the input. I'm not sure that I would want to merge this one though! here is my logic!

Melvanimate is a library designed to allow you to add your own effects to an esp8266 to drive ws2812 via an esp8266. in all cases you can specify in the sketch which effects you want to include, which wifi network u want, or use the espmanager.

This pull request would be misleading as there is no effect called Default, so unless you have created a Default effect it won't do anything. The example sketch is just that an example sketch for you to design your own around, and show you the bare minimum, or fully a functional example to get going! There is merit to your suggestion but i think it should live in your own sketch not the example.

I for example have a load of stuff in my 'melvanimate' sketch including.. wemos code to work with alexa, the push button to turn on/reset/factory reset code i shared earlier, file browser etc... so there is lots of stuff not in the example, but you are free to include them.

does that make sense?

@probonopd
Copy link
Author

probonopd commented Dec 11, 2016

Yes, but would it hurt to have a default in the example which happens to do nothing if you don't explicitly set up a "Default" effect? Btw, i'd love to see an example of how to signal things from an API, e.g., IFTTT.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants