Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

unix: refactor uv__fs_copyfile() logic #14

Merged
merged 1 commit into from
Oct 31, 2019
Merged

unix: refactor uv__fs_copyfile() logic #14

merged 1 commit into from
Oct 31, 2019

Commits on Oct 30, 2019

  1. unix: refactor uv__fs_copyfile() logic 

    The Unix/macOS uv__fs_copyfile() implementation falls back to
using uv_fs_sendfile(). This commit refactors the error handling
to use the sendfile() req's result field, which is an ssize_t
instead of using the return value, which is an int. The int
value was coming back as a negative number for some large files.

Refs: nodejs/node#30085
PR-URL: #2533
Reviewed-By: Santiago Gimeno <[email protected]>
Reviewed-By: Saúl Ibarra Corretgé <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
    @cjihrig
    cjihrig committed Oct 30, 2019
    Configuration menu
    Copy the full SHA
    780c08a View commit details
    Browse the repository at this point in the history