Feature/string analysis #2
Open
+11,030
−84
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
florian-kuebler
requested changes
Jan 7, 2020
| * often. | ||
| * | ||
| * The analysis can be configured by passing the following optional parameters: `class` (the class | ||
| * to analyze), `granularity` (fine- or coarse-grained; defines which information will be gathered |
| analyzeString(sb.toString()); | ||
| } | ||
|
|
||
| // @StringDefinitions( |
There was a problem hiding this comment.
Please remove code block
| "properties/string_analysis/StringDefinitions.class" | ||
| ) ++ filesToLoad | ||
| val basePath = System.getProperty("user.dir")+ | ||
| "/DEVELOPING_OPAL/validate/target/scala-2.12/test-classes/org/opalj/fpcf/" |
There was a problem hiding this comment.
Having the fixed path here seems to be dangerous. Why is this needed at all?
| * results on irreducible loops. For further information, see | ||
| * [[http://www.cs.princeton.edu/courses/archive/spring03/cs320/notes/loops.pdf]]. | ||
| */ | ||
| def findNaturalLoops(): List[List[Int]] = { |
There was a problem hiding this comment.
@errt or @pmuellerda, could you review that method?
| PostDominatorTree( | ||
| if (exitNodes.length == 1) Some(exitNodes.head) else None, | ||
| i ⇒ exitNodes.contains(i), | ||
| // TODO: Pass an IntTrieSet if exitNodes contains more than one element |
There was a problem hiding this comment.
Looks like these two TODOs should be addressed before merging.
| * instance of these classes are passed. Otherwise, an exception will be thrown! | ||
| */ | ||
| def processConcatOrOrCase(subtree: StringTree): StringTree = { | ||
| if (!subtree.isInstanceOf[StringTreeOr] && !subtree.isInstanceOf[StringTreeConcat]) { |
There was a problem hiding this comment.
There are a couple of isInstanceOf/asInstanceOf that could be replaced by pattern matching.
| * the possible string values. This method returns either a final [[Result]] or an | ||
| * [[InterimResult]] depending on whether other information needs to be computed first. | ||
| */ | ||
| private def determinePossibleStrings( |
There was a problem hiding this comment.
please try to reduce the method size.
| * @return Returns a final result if (already) available. Otherwise, an intermediate result will | ||
| * be returned. | ||
| */ | ||
| private def continuation( |
There was a problem hiding this comment.
please try to reduce the method size
| */ | ||
| def isStringBuilderBufferToStringCall(expr: Expr[V]): Boolean = | ||
| expr match { | ||
| case VirtualFunctionCall(_, clazz, _, name, _, _, _) ⇒ |
There was a problem hiding this comment.
you could add "toString" as name directly
| private def interpretToStringCall( | ||
| call: VirtualFunctionCall[V] | ||
| ): EOptionP[Entity, StringConstancyProperty] = | ||
| // TODO: Can it produce an intermediate result??? |
…it gets printed when a test fails.
…ded to a StringBuilder.
… another string variable in order to produce (more) correct results. Test methods were added as well.
…or those reflective calls where strings are input and then approximates these strings values using the string definition analysis.
… should capture all relevant calls) and is much faster).
… changed the the routine that detects dependees as well as the way the intermediate result(s) is handed to have the correct information at the end of the analysis.
…t "public static final") is read, it is not further analyzed but the lower bound is returned. However, fields marked as "public static final String..." can be analyzed (see added test methods).
…ting related files had to be changed. However, the test case 'secondStringBuilderRead' works now.
…d. This required refinements in different routines.
…es in the path finding procedure.
…within a project and how often. # Conflicts: # DEVELOPING_OPAL/tools/src/main/scala/org/opalj/support/info/ClassUsageAnalysis.scala
…s well as String{Builder, Buffer}).
…d items to the property store (as the interface has changed)
…mediate results to avoid endless loops that arise due to constantly changing upper bounds (for a discussion, see InterproceduralComputationState#appendToInterimFpe2Sci).
…e the JDK for the evaluation.
… be any string, from "\w" to ".*" as this complies with the regular expression semantics.
…the end PC of a catch node is -1.
…side can be smaller than the start side.
…igurable, i.e., a threshold when to approximate field reads as the lower bound.
…ittle bug was introduced which lead to the fact that "^null$" would not be added to the possible strings if there was not field write access. This is now fixed.
…bound. This lead to one little refinement in the VirtualFunctionCallPreparationInterpreter.
…, with the lower bound.
…nalysis-new-develop
…nalysis-new-develop
florian-kuebler
force-pushed
the
feature/StringAnalysis
branch
from
544cec5 to
d4a7195
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implementation of the string analysis (the interprocedural as well as the intraprocedural variant).
Original PR by PatrickN.