Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #327
For
model_path
(or equivalent inputs e,g,model
), this addsmlip_model
as an info label when structures are output.For strings and paths, this is fine. For already-loaded torch models, it's less clear what the best label is, so I'm open to alternatives.
This will also interact with any implementation of #240, but we can deal with that when we come to it.
@alinelena, was the suggested
info['{arch}_{model}'] = model
replacinginfo["arch"]
or additional? To me it doesn't make sense to have"{arch}_model"
as well as"arch"
, which is how I originally interpreted it, but perhaps it makes sense to combine them into a single info label, which I just realised may be what you meant.